-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update homepage on PyPI. #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It takes a new entry in CHANGELOG.md
to document the difference between version 0.0.9
and version 0.0.10
.
@mkcor OK -- added an entry. I'm wondering if we need to add CHANGELOG entries for every single patch (that seems a little excessive, especially when it's something as minor as this that doesn't affect how the package behaves at all). |
For example, the CHANGELOG for Dash (https://github.com/plotly/dash/blob/master/CHANGELOG.md) is only updated for minor versions. |
Ok. I think you're misinterpreting what I said. It's the other way around. I'm only asking for a CHANGELOG entry because you bumped up the version number. Personally, I would have made this tiny change without changing versions... and all this (including WIP docs) would have been smoother and faster. But if you go from 0.0.9 to 0.0.10 (which I don't think was necessary, I actually think it's a bit odd), somehow you have to justify it... right? I still don't understand why you bumped version number to 0.0.10, but now that you did, I'm trying to make it work somehow. |
Actually, you do have to bump the version number to edit the metadata. See discussion here: pypi/warehouse#2170 (comment) |
Looking at the CHANGELOG for Dash, it doesn't seem related to anything major/minor/patch/rc. It looks like it's updated whenever there's a version updated, whether minor or patch or anything. |
Ah, you're correct! Didn't scroll down far enough :) |
That's super interesting, thanks for sharing. But here I'm not really arguing about whether to increment versions or not. Rather, I'm arguing that if you do so, then you want to document it. Do you mind rerunning CI to get those tests to pass? |
Closes #339
Before merging